Do not set Accept header twice
#28598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KN4CK3R
added
the
skip-changelog
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
delvh
changed the title
Accept headerAccept header twice
delvh
approved these changes
Dec 23, 2023
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Dec 23, 2023
GiteaBot
added
lgtm/done
lunny
approved these changes
Dec 24, 2023
|
How about removing another |
|
Then you would have to set that header on every call which is the opposite of what should be done. |
Why not? It will be clearer than before? |
|
How is it clearer to set a mandatory value outside a method called by every place? Currently we have a method |
Only 4 places invoking |
|
Ok, I disagree on that one. |
|
Anyway, let's merge this one first. |
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 29, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin switch destination directory for apt signing keys (go-gitea#28639) Extend description for ARTIFACT_RETENTION_DAYS (go-gitea#28626) Refactor timeutil package (go-gitea#28623) Refactor some legacy code and remove unused code (go-gitea#28622) Remove unnecessary syncbranchToDB with tests (go-gitea#28624) Do not set `Accept` header twice (go-gitea#28598) [skip ci] Updated translations via Crowdin fix wrong link in user and organization profile when using relative url (go-gitea#28617) Add get actions runner registration token for API routes, repo, org, user and global level (go-gitea#27144) Fix session key conflict with database keyword (go-gitea#28613)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Revert go-gitea#28550 Don't add the `Accept` header twice.
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Revert go-gitea#28550 Don't add the `Accept` header twice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #28550
Don't add the
Acceptheader twice.